Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVAE_model.py - von mises reconstruction loss #94

Open
chrismessenger opened this issue Nov 21, 2020 · 0 comments
Open

CVAE_model.py - von mises reconstruction loss #94

chrismessenger opened this issue Nov 21, 2020 · 0 comments
Assignees
@hagabbar

Comments

@chrismessenger
Copy link
Collaborator

chrismessenger commented Nov 21, 2020 •
edited

Why is the reconstruction loss summed on line 581 over the 1st and 2nd elements of the 2nd dimension?

It looks like this a hard coded assumption that there are 2 von mises parameters. I think at present that is true with phi_jl and phi_12 but it isn't always the case.

Just sum it over the 2nd dimension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hagabbar hagabbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hagabbar @chrismessenger