diff --git a/matminer/featurizers/composition/alloy.py b/matminer/featurizers/composition/alloy.py index bc661df5..e3b29773 100644 --- a/matminer/featurizers/composition/alloy.py +++ b/matminer/featurizers/composition/alloy.py @@ -719,7 +719,7 @@ def featurize(self, comp): atomic_fraction = self.compute_atomic_fraction(elements, comp) yang_delta = self.yss.compute_delta(comp) yang_omega = self.yss.compute_omega(comp) - ape = AtomicPackingEfficiency().compute_simultaneous_packing_efficiency(comp)[0] + ape = AtomicPackingEfficiency(impute_nan=self.impute_nan).compute_simultaneous_packing_efficiency(comp)[0] radii_local_mismatch = self.compute_local_mismatch(miracle_radius_stats["array"], fractions) radii_gamma = self.compute_gamma_radii(miracle_radius_stats) S_config = self.compute_configuration_entropy(fractions) diff --git a/matminer/featurizers/composition/composite.py b/matminer/featurizers/composition/composite.py index f13269c4..86d93fe1 100644 --- a/matminer/featurizers/composition/composite.py +++ b/matminer/featurizers/composition/composite.py @@ -55,8 +55,6 @@ class ElementProperty(BaseFeaturizer): def __init__(self, data_source, features, stats, impute_nan=False): self.impute_nan = impute_nan - if not self.impute_nan: - warnings.warn(f"{self.__class__.__name__}(impute_nan=False):\n" + IMPUTE_NAN_WARNING) if data_source == "pymatgen": self.data_source = PymatgenData(impute_nan=self.impute_nan) elif data_source == "magpie": diff --git a/matminer/featurizers/composition/packing.py b/matminer/featurizers/composition/packing.py index 0cabf8ac..2bb5a0b2 100644 --- a/matminer/featurizers/composition/packing.py +++ b/matminer/featurizers/composition/packing.py @@ -82,7 +82,7 @@ def __init__(self, threshold=0.01, n_nearest=(1, 3, 5), max_types=6, impute_nan= self.impute_nan = impute_nan if not self.impute_nan: warnings.warn(f"{self.__class__.__name__}(impute_nan=False):\n" + IMPUTE_NAN_WARNING) - self._data_source = MagpieData(impute_nan=impute_nan) + self._data_source = MagpieData(impute_nan=self.impute_nan) # Lookup table of ideal radius ratios self.ideal_ratio = dict(