Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple languages #62

Open
patcon opened this issue May 23, 2018 · 2 comments
Open

Add support for multiple languages #62

patcon opened this issue May 23, 2018 · 2 comments

Comments

@patcon
Copy link

patcon commented May 23, 2018

I've always had a hard time getting English-speaking groups to use Hackfolder, and it seems to mostly be a reflection of the non-English language communicating "this is not for you".

I'd like to discuss how multilingual support (i18n) might be possible :)

Here are some thoughts -- 🔍 facts, feelings ❤️ and 💡 ideas -- related to this issue:

  1. 🔍 hackfoldr is totally client-side
  2. 🔍 Multilingual support on same page can hurt SEO.
  3. 🔍 The recommended tactic for best SEO is to use different routes for each language: example.com/en/:slug
  4. 🔍 No pages of hackholdr.org or subdomains are indexed in Google right now.
  5. ❤️ I feel that perhaps we could ignore SEO advice because we already aren't very SEO-compatible.
  6. 🔍 i18next is a popular multilingual JS framework.
  7. ❤️ I feel uncertain whether i18next is right for us
  8. 🔍 i18next has a browser language detector plugin for apps like hackfoldr.
  9. 💡 We could use i18next without language routes, since we're not getting hit by SEO and this will be minimal change from current hackfoldr.
  10. 🔍 i18next can easily pull translations from a url stored at one of the app's endpoints.
  11. 🔍 This is a codepen example of the simple behavior described above.
  12. 💡 The MVP could use javascript's navigator property to auto-detect language.
  13. 💡 We could later add a langauge selector and use the detector's cookie/localStorage features.
@patcon
Copy link
Author

patcon commented May 23, 2018

Open Questions

  1. Am I posting this in the right place?
  2. Where do I submit the pull request?
  3. Do you think this is a good idea?
  4. Who makes merge decisions? Would it be a welcome addition in their opinion?
  5. Is the described approach a decent one? Should more research be done?

@patcon
Copy link
Author

patcon commented May 24, 2018

Working on translations here: https://gist.github.com/patcon/1f68d3efd30360048bce81b3a7655c5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant