Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently the nav title also scroll while scrolling the page #270

Open
sagarchoudhary96 opened this issue Oct 17, 2020 · 6 comments
Open

Comments

@sagarchoudhary96
Copy link

sagarchoudhary96 commented Oct 17, 2020

It would be good to make the navbar fixed and scroll the content as the side list navigation is all fixed so the spacing on top of it looks odd after scroll.
Oct-17-2020 20-07-02

@hackerkid Should i fix it and raise the PR?

@hackerkid
Copy link
Owner

hackerkid commented Oct 17, 2020

@sagarchoudhary96 I think some of the PRs that are opened already will fix that. I will let you know if it doesn't fix so that you can work on that then. For now maybe try to improve something else. Maybe create a PR to make the background color better? The white background is kind of annoying.

@VinamraGuptaa
Copy link

Hello. Is this issue still open? Are there any other issue? I would love to contribute. Thank You

@hackerkid
Copy link
Owner

@VinamraGuptaa Yes. It's open. You can see the website at https://books.vishnuks.com/

It would be awesome if you create a PR that keeps the navbar fixed. Maybe the side menu as well? But that could be another PR.

@hackerkid
Copy link
Owner

hackerkid commented Oct 27, 2020

Actually since @sagarchoudhary96 opened this issue, I would let him take over this issue if he is interested in creating a PR.

@VinamraGuptaa You can work on keeping the side menu (which shows the categories) fixed?

Does that makes sense to you folks? If yes feel free to start on working!

@sagarchoudhary96
Copy link
Author

@VinamraGuptaa you can take this one too ahead and fix it too along with the side menu changes.

@MohamedAli00949
Copy link

Hi, I have shown the website and noticed that

  • The header is at the end of the screen and doesn't appear on the small screens.
  • The sidebar is not fixable while scrolling.

You can show my screenshots for that at the end of the comment.
So I want to fix this issue and I hope to assign it to me.

Screenshot 2023-10-02 231824
Screenshot 2023-10-02 230127
Screenshot 2023-10-02 230043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants