Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Modal Component #501

Open
vasuchal opened this issue Nov 22, 2021 · 0 comments
Open

General Modal Component #501

vasuchal opened this issue Nov 22, 2021 · 0 comments
Labels
P2 Low Priority

Comments

@vasuchal
Copy link
Member

vasuchal commented Nov 22, 2021 •
edited

Description

Many of our modal components share the same base structure and CSS. For efficiency and readability, it would be best to create a base Modal component that all Modals components will use. CSS can be mimicked from EditRoleModal.scss.

Todo

These points are a rough guideline. Please feel free to discuss with others on the team about the best way to design this component!

  • Create a base Modal component that all Modals components will use
  • Use CSS from EditRoleModal or other modal components and create div class structures
  • Move all modal components to folder "Modals"
@mattwalo32 mattwalo32 added the P2 Low Priority label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattwalo32 @vasuchal