New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libplacebo forces c++_shared #256
Comments
Patches welcome. If you have better solution for sane convert.cc implementation. As for crashes it is your job to ensure proper standard library is used. You have not provided what actually crashes and since there is not c++ in api boundary I doubt the crashes are caused by libplacebo itself. |
Remind me, what was the reason we switched from our implementation to |
Because there were issues with NIHed parser not working in some corner cases and had quirks like printing
As for C++ std lib issue, linking statically is an option and will pull only small part of it. |
It may just be a special need of mine, and many people may not care about it. I believe that the current implementation in C++ is quite concise. After handling some urgent matters, I will try my best to experiment with some other methods, such as this: https://github.com/hermantb/fast_convert.git I'm not sure if it covers part of our needs or is completely unrelated. |
After upgrading mpv recently, it consistently crashes at random during runtime. After extensive Googling, I discovered that a possible cause might be that my program is linking to two incompatible libc++ runtimes, one of which is from the vendors SDK library. However, both mpv and libplacebo are pure C, with the exception of the recently introduced convert.cc. Is it possible to remove the dependency on c++_shared? Although it's very useful, is it necessary to introduce a C++ dependency in a pure C project?
the C++ dependency also significantly increases the app download/install size by requiring the unneeded library. The libc++_shared.so is nearly 1MB (911696 bytes) as seen in app/build/intermediates/stripped_native_libs/release/out/lib/arm64-v8a.
The text was updated successfully, but these errors were encountered: