Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website download file #2147

Closed
greenchili opened this issue Aug 20, 2019 · 20 comments
Closed

Website download file #2147

greenchili opened this issue Aug 20, 2019 · 20 comments

Comments

@greenchili
Copy link

Hi, this is a feature request I suppose. The zip file download from the home page is a bit of a 'zip bomb'. I think it would be better to unzip into a contained folder as this can be quite annoying.

@roblarsen
Copy link
Member

Hi, can you further describe your issue with the zip file? I can guess what you mean, but I would only be guessing.

@greenchili
Copy link
Author

Download the zip file from the site:
The file from your main site:

https://github.com/h5bp/html5-boilerplate/releases/download/v7.2.0/html5-boilerplate_v7.2.0.zip

It unzips the files directly to the destination directory rather than a self contained folder.

@coliff
Copy link
Member

coliff commented Aug 21, 2019

Extracting any ZIP by default extracts to a folder with the same name as the ZIP. If I right-click extract it (by default) gets extracted to a 'html5-boilerplate_v7.2.0' folder on Windows 10. I just tested on MacOS 10.14.6 too and it does the same. So it works well and as expected.

If it were to be in an additional folder it's actually more hassle and annoying as its an additional folder to dig down to.

@greenchili
Copy link
Author

I am unzipping on linux cli using the standard unzip command:
unzip --help
UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP.

@webhat
Copy link

webhat commented Aug 22, 2019

I can confirm, it unzips into the current working directory.

I am unzipping on linux cli using the standard unzip command:
unzip --help
UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP.

@coliff
Copy link
Member

coliff commented Aug 22, 2019

ah ok. Maybe UnZip for Linux needs an update so it behaves like Windows and MacOS then :-)

Really, there isn't anything that can realistically be done here. The GitHub ZIP release just takes the files from the repo and makes it available as a ZIP as is so the only way round that would be to put everything in a folder first, but that'd be quite odd (I've never seen another GitHub repo do that) - and it'd annoying for all Windows and MacOS users.

@roblarsen
Copy link
Member

To be precise the download file that Github produces is different than the release zip file. The release zip file is intentionally structured this way so that the unzipped folder on Mac or Windows is nice and tidy. I am sorry I've never tried the download file on linux. For now, the dowload file of latest or the tag generated by Github (literally browsing to the tag and clicking the "clone or download" button) won't be as clean (it will just be the project folder) but will be contained inside a folder.

@greenchili
Copy link
Author

OK if you feel this a non issue then please close.

@eclectic-coding
Copy link

For what it's worth, the ZIP file downloaded from Github (using Ubuntu ARCHIVE extracts into a new directory named HTML5-BOILERPLATE-MASTER. However, when the file is downloaded from the web site there is not root directory to extract into, the user has to direct to a new empty directory. I see what @greenchili is referring to.
IMHO, these archives should behave the same.

@roblarsen
Copy link
Member

Some notes:

The zip from Github is different than the released zip file. I have control over one and no control over the other.

The file we include with the release is the dist folder. I intentionally zip it up so that (on Mac and Windows at least) it behaves in the way we're describing here. You perform the default unzip action and the folder output is the contents of the dist folder. We've since learned that's not optimal on Linux. Since it's a legit issue I'm leaving this open. If there's a way to make the release better AND be nice to linux users than that would be something I would do for the next release.

The zip file from Github is just a snapshot of the state of the repo that you're viewing. I don't have any control over how that is zipped up.

@jms1989
Copy link

jms1989 commented Sep 17, 2019

file-roller on linux unzips to a folder named the same as the zip file when done from the file manager.

you can just do:

mkdir html5-boilerplate
unzip html5-boilerplate*.zip -d html5-boilerplate

@roblarsen
Copy link
Member

That might be the best we can do, document it in that way.

@cn-wwb

This comment has been minimized.

@acluther
Copy link

Has the documentation been updated to reflect the ZIP file behavior? I'd be glad to take it on if not.

@roblarsen
Copy link
Member

@acluther it has not. You can definitely take it on. I'm just queuing up the project for a new release so your timing is excellent.

@acluther
Copy link

acluther commented Oct 22, 2019

@roblarsen great, I'll work on it this evening.

@roblarsen
Copy link
Member

@acluther if you're still interested I'd love to include this update in the upcoming release

@Diraneh
Copy link

Diraneh commented Nov 1, 2019

Bonjour,

Il faut d'abord compresse votre donnée dans un fichier en zip et puis

Téléchargez mon super fichier

.

@acluther
Copy link

acluther commented Nov 2, 2019

@acluther if you're still interested I'd love to include this update in the upcoming release

I had every good intention of getting on it but other things ended up taking priority. I apologize but would like to be involved in the future.

@roblarsen
Copy link
Member

closed via #2169 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants