Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSTD_c_experiencelParam6 issue not found #270

Open
wk1583241477 opened this issue Mar 28, 2024 · 7 comments
Open

ZSTD_c_experiencelParam6 issue not found #270

wk1583241477 opened this issue Mar 28, 2024 · 7 comments

Comments

@wk1583241477
Copy link

image

The error message is as follows:

error[E0432]: unresolved import zstd_sys::ZSTD_cParameter::ZSTD_c_experimentalParam6
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zstd-safe-6.0.6/src/lib.rs:609:13
|
609 | ZSTD_c_experimentalParam6 as ZSTD_c_targetCBlockSize,
| -------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| no ZSTD_c_experimentalParam6 in ZSTD_cParameter
| help: a similar name exists in the module: ZSTD_c_experimentalParam1

make[3]: Leaving directory '/home/wk/milvus/cmake_build'afe
[ 60%] Built target knowhere
make[3]: Entering directory '/home/wk/milvus/cmake_build'
For more information about this error, try rustc --explain E0432.
error: could not compile zstd-safe (lib) due to previous error

@nickkaltner
Copy link

for anyone encountering this change, you can do the following to work around it;

[dependencies]
zstd-sys = "=2.0.9"

which locks the compatible version

@DragisBlade
Copy link

DragisBlade commented Apr 4, 2024

Hence this build is official and the newest available version, automatic updates will download it. Resulting in a major issue for all users doing
cargo update

For me, it drawed the broken build as a deep dependency of tantivy today and it took me quite a while to find this issue-post.

@frnsys
Copy link

frnsys commented Apr 4, 2024

Really frustrating that such a breaking change was introduced.

For others who encounter this problem because of a transitive dependency, I added the following to my Cargo.toml:

[patch.crates-io]
zstd-sys = { git = "https://github.com/gyscos/zstd-rs.git", rev = "1779b385b42b08f958b767a37878dfa6a0b4f6a4" }

and then ran cargo update. This will use the commit before the change.

@gyscos
Copy link
Owner

gyscos commented Apr 4, 2024

To be clear, it only happens when all of these situations combine:

  • An old version of zstd-safe is used
  • the experimental/unstable flag is explicitly requested - this acts as a deliberate choice to deal with such changes
  • The version of zstd-sys was not locked, either through Cargo.lock or a simple exact version pin in de dependencies (no need for a patch.crates-io section).
    For example, this would lock the version, including as transitive dependency:
[dependencies]
zstd-sys = "=2.0.9"

As mentioned in #270 (comment).

@BSteffaniak
Copy link

Yes, the cause of this for me seems to be tantivy as well. It looks like this issue is related: quickwit-oss/tantivy#2339

@BSteffaniak
Copy link

BSteffaniak commented Apr 12, 2024

The issue with Tantivy has been fixed in version 0.22.0 (released about 10 hours ago). That version resolves this issue for me.

@stevemk14ebr
Copy link

The tantivy release has some breaking changes FYI

ctron added a commit to ctron/trustification that referenced this issue Apr 22, 2024
ctron added a commit to ctron/trustification that referenced this issue Apr 22, 2024
mrizzi pushed a commit to trustification/trustification that referenced this issue Apr 22, 2024
mrizzi pushed a commit to trustification/trustification that referenced this issue Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants