Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd::bulk::decompress: says "less than" instead of "less or equal" #240

Open
safinaskar opened this issue Aug 22, 2023 · 3 comments
Open

Comments

@safinaskar
Copy link

zstd::bulk::decompress: says "less than" instead of "less or equal". Using this code:

fn main() {
    let src = b"abc";
    let compressed = zstd::bulk::compress(src, 1).unwrap();
    assert_eq!(zstd::bulk::decompress(&compressed, src.len()).unwrap(), src);
}

we can verify that "less or equal" was intended

@gyscos
Copy link
Owner

gyscos commented Oct 11, 2023

Indeed, thanks for the report! Should now be fixed.

@safinaskar
Copy link
Author

Docs of function zstd::bulk::decompress still look same: https://docs.rs/zstd/0.13.0/zstd/bulk/fn.decompress.html

@gyscos
Copy link
Owner

gyscos commented Oct 12, 2023

Oh right I only updated Decompressor::decompress(). Fixing that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants