[SOLVED] cache of running PID

[themighty1]

I noticed that we spend around 200 usec for each packet in procmon.FindProcess

opensnitch/daemon/conman/connection.go

Line 123 in 8cc6569

if c.Process = procmon.FindProcess(pid, showUnknownCons); c.Process == nil {

Unless I've overlooked something, we don't need to lookup the pid in /proc for every packet. We only need to look up the pid in /proc on the first packet from that pid and then to cache that value. For all subsequent packets from that pid, FindProcess() will return the cached value.
If the pid terminates, the cached values for that pid are cleared.

[gustavo-iniguez-goya]

We only look up the PID in /proc once (and only for NEW packets), in

opensnitch/daemon/conman/connection.go

Line 111 in 8cc6569

if pid = procmon.GetPIDFromINode(inode, fmt.Sprint(inode, c.SrcIP, c.SrcPort, c.DstIP, c.DstPort)); pid == os.Getpid() {

But it's true that we enter in FindProc() and get the PID's information even if the object for that PID (Process{}) is already created. We could have a cache of Process{} as you suggested.

[themighty1]

PR submitted evilsocket#342