Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix initial view show-up issue for preset transformation #343

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: fix initial view show-up issue for preset transformation #343

merged 2 commits into from
Nov 1, 2023

Conversation

guoyingtao
Copy link
Owner

No description provided.

@guoyingtao guoyingtao mentioned this pull request Nov 1, 2023
Closed
@xinatanil
Copy link

Not exactly what I meant, now it's just a black screen and then the image appears (with correct crop info).
Possibly, because all the adjustments are being applied at viewDidAppear. Any chance to move the logic to viewWillAppear?

@guoyingtao
Copy link
Owner Author

@xinatanil
I updated the code. I think this time it should work.

Simulator Screen Recording - iPhone 15 Pro Max - 2023-11-01 at 21 23 45

@xinatanil
Copy link

Now it works as expected
Thanks!

xinatanil
xinatanil approved these changes Nov 1, 2023
View reviewed changes
Copy link

@xinatanil xinatanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🔥

@guoyingtao guoyingtao merged commit 4b94612 into master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinatanil xinatanil xinatanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guoyingtao @xinatanil