feat: Added flag to disable deformation of crop box #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoyingtao
requested changes
Apr 12, 2023
| @@ -47,11 +48,12 @@ class CropAuxiliaryIndicatorView: UIView, CropAuxiliaryIndicatorViewProtocol { | |||
| } | |||
| } | |||
|
|
|||
| init(frame: CGRect, cropBoxHotAreaUnit: CGFloat) { | |||
| init(frame: CGRect, cropBoxHotAreaUnit: CGFloat, disableCropBoxDeformation: Bool) { | |||
There was a problem hiding this comment.
Can you add a default value for disableCropBoxDeformation here, otherwise we need to update CropAuxiliaryIndicatorViewTests too.
| @@ -28,6 +28,10 @@ extension CropView { | |||
| } | |||
|
|
|||
| private func isHitGridOverlayView(by touchPoint: CGPoint) -> Bool { | |||
| guard !cropViewConfig.disableCropBoxDeformation else { | |||
| return false | |||
| } | |||
There was a problem hiding this comment.
Can you move this logic to where isHitGridOverlayView is called? Otherwise when cropViewConfig.disableCropBoxDeformation is true, it returns false but it actually hit the GridOverlayView. The logic works but not accurate as the function name describes.
…ceived in the initializer of CropAuxiliaryIndicatorView
|
@guoyingtao |
guoyingtao
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I want to disable the deformation of the crop area, so I have added a flag for that.