feat: add mirror mode support #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoyingtao
force-pushed
the
mirror-mode
branch
from
79e0527
to
880f8ae
Compare
issues to be solved UI is broken when rotating device
guoyingtao
force-pushed
the
mirror-mode
branch
from
880f8ae
to
549f8ac
Compare
rename handleRotate to handleDeviceRotated chore: remove deprecated comment
guoyingtao
force-pushed
the
mirror-mode
branch
from
b46c814
to
4cb8011
Compare
Closed
vanniktech
requested changes
Aug 27, 2022
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| enum ImageRotationType: CGFloat { | |||
| public enum ImageRotationType: CGFloat { | |||
There was a problem hiding this comment.
Why do we need this to be public now?
There was a problem hiding this comment.
I think I forgot deleting some test code. I will remove public
|
|
||
| static func verticallyFlipImage() -> UIImage? { | ||
| if #available(macCatalyst 13.1, iOS 13.0, *) { | ||
| guard let horizontallyFippedImage = horizontallyFlipImage(), |
There was a problem hiding this comment.
Nice idea that you just take the other icon and rotate / translate it!
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
use didSelectHorizontallyFlip and didSelectVerticallyFlip
vanniktech
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.