feat: Customize crop toolbar color #178
Conversation
Add CropToolbarConfig to CropToolbarProtocol
extract Config, Definition and Enum from Mantis.swift fix some typos
| @@ -21,7 +21,7 @@ Pod::Spec.new do |s| | |||
| s.social_media_url = "http://twitter.com/guoyingtao" | |||
| s.platform = :ios | |||
| s.swift_version = "5.0" | |||
| s.ios.deployment_target = "11.0" | |||
There was a problem hiding this comment.
Same question as here: #177 (comment)
There was a problem hiding this comment.
It is because of my previous PR #169
I added a CropToolbarIconProvider also I decided to use SF Symbol for CropToolbar icons instead of drawing them by myself, which needs iOS 13.
With apple's iOS 16 coming soon, I think it might be a good timing to move to iOS 13 because it also supports Combine, SwiftUI etc.
There was a problem hiding this comment.
I know that iOS 16 is coming soon, and from a developers perspective we always want higher min versions. I personally still support up to 12+
Other than asking nicely, is there anything I can do so that you consider supporting 12+? I know the benefit of using SF Symbols is nice, but it's not even like we are able to replace all images with symbols.
There was a problem hiding this comment.
If you still want to support iOS 12 for a while, I think I need to create a dedicated branch for it then rebase new code, make dedicated releases from that branch.
There was a problem hiding this comment.
I'd very much appreciate that.
No description provided.