feat: add showAttachedCropToolbar option to CropToolbarConfig #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoyingtao
changed the title
vanniktech
reviewed
Jul 11, 2022
Mantis.podspec
Outdated
| @@ -21,7 +21,7 @@ Pod::Spec.new do |s| | |||
| s.social_media_url = "http://twitter.com/guoyingtao" | |||
| s.platform = :ios | |||
| s.swift_version = "5.0" | |||
| s.ios.deployment_target = "11.0" | |||
There was a problem hiding this comment.
Is this change really necessary? I still have deployment_target = "12.0" for my app
There was a problem hiding this comment.
It is because of my previous PR #169
I added a CropToolbarIconProvider also I decided to use SF Symbol for CropToolbar icons instead of drawing them by myself, which needs iOS 13.
With apple's iOS 16 coming soon, I think it might be a good timing to move to iOS 13 because it also supports Combine, SwiftUI etc.
|
@vanniktech |
change CocoaPods deployment target 13.0 update an example to show showNativeCropToolbar's support remove some unnecessary self
rename showBottomCropToolbar to showAttachedCropToolbar
add getCancelIcon and getCropIcon to CropToolbarIconProvider protocol
guoyingtao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #173
@vanniktech
I added showBottomCropToolbar option to CropToolbarConfig, you can check the example
Hide Rotation Dial