Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support to set the rotation limits #148

Merged
merged 4 commits into from Nov 16, 2021
Merged

feat: added support to set the rotation limits #148

merged 4 commits into from Nov 16, 2021

Conversation

7blueXY
Copy link
Contributor

@7blueXY 7blueXY commented Nov 11, 2021

We wanted to have the ability to rotate an image with no limits. It was hardcoded to 45 degrees. Now the default is 45 degrees but users of this package can override it and set there own limits or no limits.

Copy link
Owner

@guoyingtao guoyingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Sources/Mantis/CropView/CropView.swift Outdated Show resolved Hide resolved
Sources/Mantis/CropView/CropView.swift Outdated Show resolved Hide resolved
Sources/Mantis/CropView/CropView.swift Outdated Show resolved Hide resolved
Sources/Mantis/RotationDial/DialConfig.swift Outdated Show resolved Hide resolved
Sources/Mantis/CropView/CropView.swift Show resolved Hide resolved
Sources/Mantis/Mantis.swift Outdated Show resolved Hide resolved
@7blueXY
Copy link
Contributor Author

7blueXY commented Nov 16, 2021

made DialConfig its own file again...

@guoyingtao guoyingtao changed the title added support to set the rotation limits feat: added support to set the rotation limits Nov 16, 2021
@guoyingtao guoyingtao merged commit 8feece0 into guoyingtao:master Nov 16, 2021
@7blueXY
Copy link
Contributor Author

7blueXY commented Nov 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants