chore!: Normalize repository, dropping node <10.13 support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
Oct 8, 2022
phated
reviewed
Oct 8, 2022
phated
reviewed
Oct 8, 2022
phated
reviewed
Oct 8, 2022
phated
reviewed
Oct 8, 2022
phated
reviewed
Oct 8, 2022
|
@phated I've modify what you pointed out. Please review this PR again. |
phated
reviewed
Oct 10, 2022
phated
reviewed
Oct 10, 2022
phated
reviewed
Oct 10, 2022
phated
reviewed
Oct 10, 2022
phated
reviewed
Oct 10, 2022
phated
reviewed
Oct 11, 2022
phated
reviewed
Oct 11, 2022
Comment on lines
+259
to
+263
| function normalizeRelpath(fp) { | ||
| // Since we only ever operate on relative paths, | ||
| // this utility shouldn't need to handle path roots | ||
| return path.posix.normalize(fp.replace(/\\/g, '/')); | ||
| } |
There was a problem hiding this comment.
@sttk Please review this change and verify my research/assumption is correct.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this project:
NOTICE: this package depends on vinyl and now-and-later which will be bumped up.