Update: Export and test resolveConstant method separately #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
export-resolve-constants
branch
from
e180b8a
to
b4b6763
Compare
phated
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
I rebased this on the scaffold updates and tweaked a couple tests for the new expect library.
Sorry this has been open for like 5 years @erikkemperman 🤦
|
Haha, I’d forgotten about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to rebasing this. Use cases as in #1 (comment) and also the idea of using node-glob's caches to prevent spurious filesystem calls in vinyl-fs.