Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Normalize repository, dropping node <10.13 support #3

Merged
merged 3 commits into from Jan 10, 2022

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Dec 25, 2021

This PR updates this project:

  • Updates dependency versions
  • Update GitHub Actions files
  • Adds, changes and deletes some project files

LICENSE Outdated Show resolved Hide resolved
package.json Outdated
"remove-bom-buffer": "^3.0.0",
"through2": "^2.0.3"
"safe-buffer": "^5.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to drop safe-buffer completely, it was a holdover for the old buffer support

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have done this as a review. We want to remove safe-buffer in this change.

@sttk
Copy link
Contributor Author

sttk commented Jan 8, 2022

@phated I've removed safe-buffer. Please review this PR again.

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sttk! I also opened #4 and #5 for follow ups before we release this next version.

@phated phated merged commit 8fece9c into gulpjs:master Jan 10, 2022
@github-actions github-actions bot mentioned this pull request Jan 10, 2022
@sttk sttk deleted the chore-normalize-repository branch January 15, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants