Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Normalize repository, dropping node <10.13 support #8

Merged
merged 1 commit into from Nov 22, 2021

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Nov 21, 2021

This PR updates this project:

Updates dependency versions
Introduces GitHub Actions
Adds, changes and deletes some project files

In test, expect.spyOn was replaced to jest.spyOn (in @jest/globals) and it can be only used inside of the Jest test environment. Therefore I changed it to using sinon.

@sttk sttk requested a review from phated November 21, 2021 10:27
@phated phated added this to In progress in v5 Nov 22, 2021
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks so much to working on these @sttk 🍻

@phated phated merged commit 4b17b49 into gulpjs:master Nov 22, 2021
@phated phated moved this from In progress to Done in v5 Nov 22, 2021
@github-actions github-actions bot mentioned this pull request Nov 22, 2021
@sttk sttk deleted the chore-normalize-repository branch November 23, 2021 04:19
@sttk
Copy link
Contributor Author

sttk commented Nov 23, 2021

@phated Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants