chore!: Normalize repository, dropping node <10.13 support #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
commented
Apr 7, 2022
test/index.js
Outdated
| @@ -134,18 +126,27 @@ describe('interpret.extensions', function() { | |||
| } | |||
| } | |||
|
|
|||
| // Any swc test after the first will fail on linux due to https://github.com/swc-project/swc/issues/4107 | |||
There was a problem hiding this comment.
Every test for swc after the first fails due to swc-project/swc#4107
Closed
phated
commented
Apr 7, 2022
| @@ -134,18 +126,27 @@ describe('interpret.extensions', function() { | |||
| } | |||
| } | |||
|
|
|||
| // Skip any swc test on linux due to https://github.com/swc-project/swc/issues/4107 | |||
There was a problem hiding this comment.
Skipping on linux until swc-project/swc#4107 is resolved.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the project scaffold to be inline with other projects. It drops node <10.13 support, which is a breaking change, but we no longer need to worry about "minVersions" of node for the tests.
There are still improvements I want to make, but I want GHA CI so I'm going to merge this in.