fix: performance improvement #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because performance with the newly-added test is not good enough without the additional help of the |
phated
reviewed
Sep 29, 2021
| if (/[^\\][{[]/.test(str)) { | ||
| return true; | ||
| } | ||
| return isGlob(str); |
There was a problem hiding this comment.
Is there anything weird (different?) by changing the order of the isGlob check and "globby" regexp test?
There was a problem hiding this comment.
Because they were OR'ed, I don't think it makes any difference logically. I'm happy to flip it back assuming that doesn't introduce performance regressions.
|
@Trott can you update the package.json to require is-glob 4.0.3? 🍻 |
Done. |
|
All green! ✅ |
phated
reviewed
Sep 29, 2021
|
Published as 6.0.2 - thanks a ton @Trott! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance measuring here is confounded a bit by an
is-globperformance gotcha that is fixed in micromatch/is-glob#15. Here's what I'm seeing runningtime node -e "require('./')('/('.repeat(500000) + ')')"on my 2013 Macbook:(The added test will likely fail without the is-glob PR, depending on how performant the test machine is.)