-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to streamx #7
Switch to streamx #7
Comments
I toyed with this locally, switching from While I was working on the code I hit three lint parser errors:
Would you be open to adding |
Thanks for digging into this! I need to do some more digging, but I thought it wasn't required to set highWaterMark for objects. With the update to node 10+, I'm fine supporting whichever syntax that runtime supports. I just didn't bother changing the parser since I wasn't planning to update rewrite libraries. |
In the current release highWaterMark is set for obj only. |
Sorry, I meant that streamx is supposed to handle hwm according to the data flowing through the stream (according to the docs, but I haven't dug into the code). All of these changes are going to be batched into a major, so we can drop the .obj method. An aside: I know you have a ton going on, but would you also be interested in joining the gulpjs core team? If not, I totally understand. |
Looks like it unconditionally sets default hwm 16384. Yes I'd be interested in joining the gulpjs core team. I can't promise consistent effort, my availability for open source tends to come in spurts. |
Yeah, that's the hwm, but The docs also mention this as
Awesome! That's pretty much all of us too. I'll send the invite now and finish setting permissions, etc up this week. |
streamx is a much better stream implementation and we should switch all the projects to use it.
The text was updated successfully, but these errors were encountered: