Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Rework errors surfaced when encountering files or symlinks #4

Merged
merged 3 commits into from
Aug 30, 2022
Merged

fix!: Rework errors surfaced when encountering files or symlinks #4

merged 3 commits into from
Aug 30, 2022

Conversation

phated
Copy link
Member

@phated phated commented Jan 15, 2018

Ref #2

@phated phated added this to In progress in v5 May 3, 2020
@phated phated marked this pull request as draft January 10, 2022 00:33
@phated phated marked this pull request as ready for review August 25, 2022 23:08
@phated
Copy link
Member Author

phated commented Aug 25, 2022

@sttk @yocontra Can either of you review these changes for me? They are primarily just making the error messages more accurate and adding a test suite for symlinks.

@phated phated changed the title Dangling link work fix!: Rework errors surfaced when encountering files or symlinks Aug 25, 2022
sttk
sttk reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated I've reviewed this PR.

mkdirp.js Show resolved Hide resolved
mkdirp.js Show resolved Hide resolved
@sttk
Copy link
Contributor

sttk commented Aug 30, 2022

@phated I think this is good. Great work!

@phated phated linked an issue Aug 30, 2022 that may be closed by this pull request
Errors with ENOENT when directory is a dangling link #2
Closed
@phated phated merged commit 3fc3dee into master Aug 30, 2022
@phated phated deleted the dangling-link branch August 30, 2022 21:04
@phated
Copy link
Member Author

phated commented Aug 30, 2022

Thanks for your review @sttk 🎉

@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Merged
@phated phated moved this from In progress to Done in v5 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttk sttk sttk left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors with ENOENT when directory is a dangling link
2 participants
@phated @sttk