Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Switch to streamx, drop .obj function #11

Merged
merged 5 commits into from
May 13, 2020

Conversation

coreyfarrell
Copy link
Member

Fixes #7


Not ready for merge as eslint-config-gulp is currently installed from a branch on my github fork.

"jest-mock": "^25.5.0",
"mississippi": "^1.3.0",
"eslint-config-gulp": "^5.0.0",
"expect": "^26.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coreyfarrell I've been thinking a lot about providing a "prelude" (been writing a lot of Rust) for gulp testing and publishing as @gulpjs/test then using it in all of the projects. I bring it up because jest just bumped versions to a major again, which means my scaffold is already behind 😭

Do you think that's a good idea or should I defer it for now? Ideally this would also help plugins test better too, but that's definitely a future thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure, I haven't gotten a chance to look very deep into the scaffold yet. In general I use tap (and more recently libtap) to do my testing so for mocha testing I have to defer to what others think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 We definitely have a unique setup with mocha but using the jest assertion stuff. I don't like the auto-mocking in jest so we didn't switch over to it completely. It also doesn't support forcing async tests, which is something I loved about lab.

I won't hang this PR on these ideas, just thought I'd ask your opinion. Sent a few more comments in a review though.

@coreyfarrell coreyfarrell marked this pull request as ready for review May 13, 2020 20:47
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things. Some I don't actually have answers for and would need to test/check.

test/index.js Outdated Show resolved Hide resolved
test/index.js Show resolved Hide resolved
test/index.js Show resolved Hide resolved
test/index.js Show resolved Hide resolved
@phated phated merged commit 8461bf9 into gulpjs:master May 13, 2020
@coreyfarrell coreyfarrell deleted the streamx branch May 14, 2020 12:13
@github-actions github-actions bot mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to streamx
2 participants