Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove pre-built browser bundle & browser tests #9

Merged
merged 6 commits into from Oct 2, 2022

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Oct 2, 2022

This PR removes code for Web browsers.

Closes #8

@sttk
Copy link
Contributor Author

sttk commented Oct 2, 2022

@phated I forgot to replace chai to expect for test code, and I've done it. Please review this PR.

README.md Outdated
Comment on lines 105 to 108
Copyright (C) 2016-2022 Gulp Team.

This program is free software under [MIT][mit-url] License.
See the file LICENSE in this distribution for more details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright (C) 2016-2022 Gulp Team.
This program is free software under [MIT][mit-url] License.
See the file LICENSE in this distribution for more details.
MIT

@phated phated changed the title Remove browser code (fixes #8) chore: Remove pre-built browser bundle & browser tests Oct 2, 2022
@phated phated changed the title chore: Remove pre-built browser bundle & browser tests chore!: Remove pre-built browser bundle & browser tests Oct 2, 2022
README.md Outdated Show resolved Hide resolved
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one change to the README but this looks great! Thanks!

@phated phated merged commit 3f75efd into gulpjs:master Oct 2, 2022
@github-actions github-actions bot mentioned this pull request Oct 2, 2022
@sttk sttk deleted the remove-browser-code branch October 2, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove browser code
2 participants