chore!: Normalize repository, dropping node <10.13 support #34
Conversation
sttk
force-pushed
the
chore-normalize-repository
branch
from
2dca685
to
e958d97
Compare
lib/helpers.js
Outdated
| @@ -2,10 +2,8 @@ | |||
|
|
|||
| var assert = require('assert'); | |||
|
|
|||
| var filter = require('arr-filter'); | |||
| var map = require('arr-map'); | |||
| // bach supports nodejs>=v10.13, but Array#flat is introduced in v11. | |||
| var flatten = require('arr-flatten'); | |||
There was a problem hiding this comment.
Should arr-flatten be replaced by Array.prototype.slice.apply?
There was a problem hiding this comment.
arr-flatten expands array elements recursively.
|
@phated I've dropped |
lib/flatten.js
Outdated
| function flatten(arr, ret) { | ||
| ret = ret || []; | ||
| for (var i = 0, n = arr.length; i < n; i++) { | ||
| var el = arr[i]; | ||
| if (Array.isArray(el)) { | ||
| flatten(el, ret); | ||
| } else { | ||
| ret.push(el) | ||
| } | ||
| } | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
When I originally designed bach, I only wanted to support this syntax:
bach.series([a, b, c], options)I don't really care if we recursively flatten, and this will be a breaking release, so I think we can use Array.prototype.slice.apply
There was a problem hiding this comment.
@phated OK. I'll modify it to use Array.prototype.slice.apply.
sttk
force-pushed
the
chore-normalize-repository
branch
from
77b41fe
to
04f75ea
Compare
|
@phated I've modified what you pointed out. |
| @@ -53,28 +56,29 @@ function buildOnSettled(done) { | |||
| } | |||
|
|
|||
| function verifyArguments(args) { | |||
| args = flatten(args); | |||
| var lastIdx = args.length - 1; | |||
| args = Array.prototype.slice.apply(args); | |||
There was a problem hiding this comment.
I need to add a semantic commit message for this potentially breaking change
This PR updates this project:
arr-filter,array-map,array-each,array-initial, andarray-lastfrom dependencies.arr-flattenis left becauseArray#flatis introduced in Node.js v11.NOTE: Be careful that this package depends on
async-done,async-settleandnow-and-laterthat will be bumped up.