Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus and keyboard nav with Adornments #3406

Open
tig opened this issue Apr 15, 2024 · 0 comments
Open

Fix focus and keyboard nav with Adornments #3406

tig opened this issue Apr 15, 2024 · 0 comments
Labels
Milestone

Comments

@tig
Copy link
Collaborator

tig commented Apr 15, 2024

Right now, in #3323, mouse works but

  • Focus does not
  • Keyboard does not work well

How should Focus work?

Because Padding is in a different view hierarchy from the dialog, Tab etc... doesn't tab into the buttons.

Padding - Any views added to Padding are included in Padding.Parent's focus chain. If View.Subviews[^1].HasFocus and the user presses Tab Padding.SubViews[0] will get focus. Etc...

Border - Ctrl-F10 is used to set focus on Border.Subviews[0]. Subsequent Tab presses cycle through Border.Subviews. Ctrl-F10 again returns focus to Border.Parent.

Margin - No default behavior. If someone adds views to Margin they are on their own to figure out a focus model (I can't think of any use case where it makes sense to add a subview to Margin.

@tig tig added the bug label Apr 15, 2024
@tig tig added this to the V2 Beta milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Approved - Need Owner
Status: 📋 Approved - Need Owner
Development

No branches or pull requests

1 participant