Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow :deprel as annotation type #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mr-martian
Copy link

closes #4

@lgessler
Copy link
Collaborator

lgessler commented Aug 6, 2022

Hi @mr-martian, thanks for the PR and sorry for the late response!

The code changes as they are actually won't be sufficient to implement this--there are other places in the code that need to change in order to accommodate DEPREL service outputs. These are, at least:

I'd work on this myself but I have higher priorities ATM so I'm not sure when I'll be able to get to it. If you'd like to keep working on implementing this, it ought to be pretty straightforward to copy and adapt what's already there for other fields, though that may be difficult depending on your familiarity with Clojure. Please let me know if there's anything else I can tell you.

@mr-martian
Copy link
Author

well, there's an attempt. I'll see about testing it properly maybe tomorrow.

@lgessler
Copy link
Collaborator

sorry this has been sitting for so long! those changes look right but I'll need to take a closer look with the code running, hopefully next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NLP Services for Deprel Labels
2 participants