Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Date Pickers to official #424

Open
fat-tire opened this issue Aug 3, 2020 · 2 comments
Open

Migrate Date Pickers to official #424

fat-tire opened this issue Aug 3, 2020 · 2 comments

Comments

@fat-tire
Copy link
Collaborator

fat-tire commented Aug 3, 2020

I haven't tried it yet but maybe switch from

implementation 'com.wdullaer:materialdatetimepicker:4.2.3'

to the official MaterialTimePicker.

It's had changes as recently as a few days ago, but if someone wants me to try it I can. Just checking interest.

@fat-tire fat-tire changed the title Migrate from Migrate Date Pickers to official Aug 3, 2020
@archie94
Copy link
Collaborator

archie94 commented Aug 4, 2020

I think the library we are using is a little more customizable, although I am not aware if we are using these customizations.

@lukeswitz
Copy link
Collaborator

.02 - I'd vote to leave this out until the major pain points are worked out.

Reasoning: it works & has no open issues for date/time selection with this codebase. Localization and date-time formats currently stable.

UI needs a proper refresh when functionality hits an acceptable mark.

A few that come to mind:

  • Onboarding Sensor Layout
  • Settings
  • Enhanced Signal setup
  • Status glyphs for server & HB
  • Separate & customizable sensor selection for legacy/flagship devices

Open to suggestions here & future as I have more time to devote to the project. Thanks all for the continued effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants