Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalafmt to the project #3151

Closed
wants to merge 2 commits into from
Closed

Add scalafmt to the project #3151

wants to merge 2 commits into from

Conversation

sihil
Copy link
Contributor

@sihil sihil commented Feb 1, 2021

What does this change?

As suggested by @Asmau1234, this adds scalafmt to the project so that we don't have to concern ourselves about dealing with formatting.

Closes #3106

TODO

  • Arrange a date and time to undertake this work when there are few pieces of work in flight
  • Add instructions to the CONTRIBUTING.md file to encourage users to use "format on save" in their IDEs
  • Adapt the editorconfig to ensure it does not interfere with scalafmt
  • Add scalafmtCheckAll to build process so that the build process fails with bad formatting

How can success be measured?

We no longer need to include formatting issues in PR feedback.

Who should look at this?

Tested?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment

@sihil sihil closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a scala formatter
1 participant