Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scala formatter #3106

Open
Asmau1234 opened this issue Jan 19, 2021 · 2 comments
Open

Add a scala formatter #3106

Asmau1234 opened this issue Jan 19, 2021 · 2 comments

Comments

@Asmau1234
Copy link
Contributor

Short description

It would be useful to have a scala formatter on the grid. It would be easier to have a consistent format across the repository.

Steps to reproduce

Actual results (including screenshots)

Expected results (including screenshots)

OS and browser details

@AWare
Copy link
Contributor

AWare commented Jan 19, 2021

Probably worth adding prettier to eslint while we're at it.

@sihil
Copy link
Contributor

sihil commented Jan 19, 2021

We need to figure out how to co-ordinate this with the BBC. We'd want to correct the formatting of all files in a single PR but it would be a major conflict for any other PRs that were in flight. As such we should probably set a day (or weekend?) when we'll do this with an aim to have no inflight PRs at the time.

@sihil sihil mentioned this issue Feb 1, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants