-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sorting by dateTaken and dateModified #1925
Comments
Also, this all-too-common "Taken on 14 Jun 2016, 02:00" Hmm... |
From my very crude tests, it looks like huge majority of all images (~3/4) haven't got time in [PROD]/search?dateField=taken&takenSince=2016-06-12T23:59:59.999Z&takenUntil=2016-06-13T00:00:01.000Z (16 289 matches) [PROD]/search?dateField=taken&takenSince=2016-06-13T00:00:01.000Z&takenUntil=2016-06-13T23:59:59.999Z (4 721 matches) |
Also, even when we read the time of |
See drewnoakes/metadata-extractor#158 and drewnoakes/metadata-extractor#344 for a method of getting composite values from multiple tags including sub-second values and time zone. Meta-isuue: drewnoakes/metadata-extractor#147. |
Greatly improved by #2180! Current reconcilliation can be improved still, MWG recommends some sensible fallbacks. Also see. We should fix sorting by |
Just adding this in case it will ever be useful (thanks, @davidfurey!): https://www.loc.gov/standards/datetime/ |
dateTaken acquiring logic much improved (see last comment). We should fix sorting by dateTaken and dateModified.
Hello,
Grid’s is not able to acquire
dateTaken
correctly. Here is a bunch of examples converted using latest Lightroom: [PROD]search?query=~"dev blog"&uploadedBy=[me]@guardian.co.ukAll dates are (and, consequently, ordering) are wrongly set at:
"dateTaken": "2016-06-10T00:00:00Z",
We already read correct
dateTaken
which is recorded in multiple places insidefileMetadata
, e.g.:Recent updates to metadata-extractor cite
Maybe if we would to update it, we wouldn’t have to think too hard about how should we reconcile the dates ourselves?
FYI, full exiftool dump reveals:
Regards
Mateusz
The text was updated successfully, but these errors were encountered: