Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture Article Byline Overlap #26776

Open
JamieB-gu opened this issue Dec 19, 2023 · 0 comments
Open

Picture Article Byline Overlap #26776

JamieB-gu opened this issue Dec 19, 2023 · 0 comments
Labels
Milestone

Comments

@JamieB-gu
Copy link
Contributor

Picture articles that are still rendered by frontend have an issue where the tags in the metadata overlap the multilines and byline. This only occurs from leftCol upwards.

Possible Solutions

The same problem does not occur in DCR, but DCR does not yet render all picture articles. It only renders them when the main media is one of the new "cartoon" elements.

val dcrCanRender =
mainBlock.exists(block => block.elements.forall(element => element.`type` == ElementType.Cartoon))

A few possible solutions:

  1. Roll out support for non-cartoons in DCR.
  2. Use the new cartoon element for these kinds of articles (Editorial workflow change).
  3. Fix the overlap issue in frontend.

Example

https://www.theguardian.com/commentisfree/picture/2023/dec/18/ben-jennings-michelle-mone-ppe-cartoon-tory-peer

overlap

@JamieB-gu JamieB-gu added the Bug label Dec 19, 2023
@JamieB-gu JamieB-gu added this to the Health milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant