Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address mystery of fixed/showcase front containers #26593

Open
cemms1 opened this issue Sep 20, 2023 · 2 comments
Open

Address mystery of fixed/showcase front containers #26593

cemms1 opened this issue Sep 20, 2023 · 2 comments
Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…
Milestone

Comments

@cemms1
Copy link
Contributor

cemms1 commented Sep 20, 2023

Background

As discussed in the Tools/Platforms catch up (20th Sept 2023), there is a gap in knowledge of how the fixed/showcase container works and when it is used.

It is specifically for Google Showcase, so that Google News receives updates in a specified format. Here's the Guardian on Google News: https://news.google.com/publications/CAAqBggKMJeqezDfswk

It should never be rendered on a normal front, but frontend does build and maintain this https://github.com/guardian/frontend/blob/main/common/app/layout/slices/FixedContainers.scala#L55, which is quite unlike Apple News which is maintained by the CoPip team (who also manage CAPI). It is not marked as "not-for-production" since it is for production; it's just never meant to be rendered directly on dotcom or in apps.

Solution

We should continue to support this container type, and ensure it is well documented in the code.

We should also ensure that DCR does not fall over in the process of rendering this, if mistakenly attempted.

@alinaboghiu
Copy link
Member

PR that introduced showcase fronts is here: #24038

A showcase front is created in the fronts tool by choosing the showcase priority on the dashboard of the fronts tool:

Screenshot 2023-09-20 at 16 30 06

The showcase containers are intended for use on the showcase front exclusively.

Cleanup Task

A showcase front should always be rendered with Frontend as it is not supported in DCR (and does not need to be). Currently, if we remove the allow list of "SUPPORTED_COLLECTIONS" from the Facia Picker, the code will attempt to render a showcase front with DCR.

We should introduce an extra check (same as we do for isRss) or better yet change the decision order in the Facia Controller, to ensure showcase fronts are always rendered with Frontend.

We should also make sure that if a showcase container is ever accidentally introduced on a regular non-showcase front, DCR is able to ignore it and now blow up.

Then we can remove the "SUPPORTED_COLLECTIONS" allow list from Facia Picker, since we will support all collections.

@cemms1 cemms1 added the Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… label Sep 20, 2023
@cemms1
Copy link
Contributor Author

cemms1 commented Sep 20, 2023

Labelled as a "pick me up" for non-scheduled work.
Note that this is very low priority as it's a bit of an edge case

@cemms1 cemms1 added this to the Health milestone Oct 4, 2023
@cemms1 cemms1 removed the Health label Oct 4, 2023
@alinaboghiu alinaboghiu removed this from the Health milestone Oct 27, 2023
@alinaboghiu alinaboghiu added this to the Health milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…
Projects
Status: Backlog
Development

No branches or pull requests

2 participants