Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic]: DCR for Apps - Discussion #8745

Open
14 of 15 tasks
Tracked by #8750
jamesgorrie opened this issue Sep 5, 2023 · 1 comment
Open
14 of 15 tasks
Tracked by #8750

[Epic]: DCR for Apps - Discussion #8745

jamesgorrie opened this issue Sep 5, 2023 · 1 comment

Comments

@jamesgorrie
Copy link
Contributor

jamesgorrie commented Sep 5, 2023

Overview

This quarter (Jan-Mar 2024) we’ll be working on implementing discussions in DCAR. We hope will reduce the amount of platform-specific logic in favour of a unified approach. We may also use this as an opportunity to simpliying existing the code and fix bugs.

Key changes required

Discussion in web and Apps differs in that in Apps post endpoints interact with the native layer directly as that's where the user information is know. e.g. postComment or reportAbuse

There has been some work to account for this by using callbacks on the CommentContainer.

When migrating discussion-rendering we had opted for expediency to not always follow this pattern, so will need to find those interactions that speak to the discussion API directly and port them over to the paradigm above.

We might need to work with Apps here to help create any endpoints that don't exist.

Step 1 - Beta release

  1. 2 of 6
    Epic
    georgeblahblah
  2. 8 of 8
    Epic
  3. help wanted question
  4. Discussion
    mxdvl
  5. georgeblahblah

Step 2 - Beta or PROD release

  1. Discussion
    DanielCliftonGuardian JamieB-gu
  2. 2 of 3
    Discussion Epic
    mxdvl
  3. 13 of 13
    Discussion Epic
  4. Discussion
    abeddow91
  5. Discussion
  6. Discussion
  7. Discussion
    JamieB-gu abeddow91

Step 3 - PROD release

  1. Discussion
    mxdvl

Unprioritised / other

  1. georgeblahblah
@mxdvl
Copy link
Member

mxdvl commented Jan 5, 2024

Rough tasks that need addressing

  • How does sign-in works with Bridget?
  • How do fetch requests work in WebViews?
  • How is saving preferences handled?
  • How should discussion behave when offline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants