Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm with DS team whether we should expose properties like line height and font weight separately #1312

Open
Tracked by #1243
sndrs opened this issue Mar 26, 2024 · 1 comment
Assignees

Comments

@sndrs
Copy link
Member

sndrs commented Mar 26, 2024

No description provided.

@jamesmockett
Copy link
Contributor

Confirmed with Akemi that we should provide the typography presets only. Designers should be using these for all designs so there is no need to deviate from the presets and override individual properties.

There may be existing uses of the typography API that use overrides and don't map to a preset. When converting code we should output an override using the raw, underlying value so as not to break anything and add a comment to review with the team's designer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants