Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog_setup tries to find spdlog but doesn't exist #77

Open
jjcasmar opened this issue Jul 8, 2021 · 0 comments
Open

spdlog_setup tries to find spdlog but doesn't exist #77

jjcasmar opened this issue Jul 8, 2021 · 0 comments

Comments

@jjcasmar
Copy link

jjcasmar commented Jul 8, 2021

I have a cmake project which fetches spdlog from git using FetchContent. This effectively defines a spdlog::spdlog target since it includes spdlog CMakeLists into my project.

Then I also fetch spdlog_setup. This step fails because spdlog_setup assumes we are going to use spdlog from deps/spdlog or from system (via find_package(spdlog REQUIRED). Since there is no package in system, it fails.

If spdlog::spdlog target is already defined, it shouldn't call find_package(spdlog REQUIRED)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant