Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_syslog_sink function causes compilation problem with recent spdlog releases #64

Open
mustafakemalgilor opened this issue Dec 17, 2020 · 0 comments

Comments

@mustafakemalgilor
Copy link

This is caused by the missing last argument. This argument is added to syslog sink constructor in commit gabime/spdlog@e68cf1c .

https://github.com/guangie88/spdlog_setup/blob/master/include/spdlog_setup/details/conf_impl.h#L861

    return make_shared<SyslogSink>(ident, syslog_option, syslog_facility);

Adding a boolean argument at the end of the list, or using the syslog sink factory fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant