Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install appdata files to /usr/share/metainfo #241

Open
sidt4 opened this issue Sep 23, 2023 · 7 comments
Open

Install appdata files to /usr/share/metainfo #241

sidt4 opened this issue Sep 23, 2023 · 7 comments

Comments

@sidt4
Copy link

sidt4 commented Sep 23, 2023

$ apt-file search /usr/share/appdata/
gtimelog: /usr/share/appdata/gtimelog.appdata.xml

...
@sidt4
Copy link
Author

sidt4 commented Sep 23, 2023

Notes:

  • Use appstreamcli validate ( and not the deprecated appstream-util validate ) command to validate appstream metainfo files.
  • The metainfo link above contains fallback appdata generated from .desktop file ( if the appdata in not installed in /usr/share/metainfo/ )

@mgedmin
Copy link
Member

mgedmin commented Sep 24, 2023

This should probably be reported to the Debian bug tracker. The upstream Makefile doesn't do anything with the appstream file, other than running appstream-util validate.

(I'll change it to use appstreamcli).

@mgedmin
Copy link
Member

mgedmin commented Sep 24, 2023

$ appstreamcli validate gtimelog.appdata.xml
E: ~:2: metainfo-ancient

This is not surprising, since I haven't touched the .appdata.xml since it was first contributed. Unfortunately the error message is also a bit terse.

I will try to force myself to read the relevant specs and see what needs to be changed. I have approximately zero motivation for this, so please do not expect a quick fix :(

@sidt4
Copy link
Author

sidt4 commented Sep 24, 2023

$ appstreamcli validate --help
Usage:
  appstreamcli [OPTION…] - AppStream CLI.

AppStream command-line interface
 'validate' command

Help Options:
  -h, --help       Show help options

Application Options:
  --pedantic       Also show pedantic hints.
  --explain        Print detailed explanation for found issues.
  --no-net         Do not use network access.
  --strict         Fail validation if any issue is emitted that is not of pedantic severity.
  --format         Format of the generated report (valid values are 'text' and 'yaml').
  --override       Override the severities of selected issue tags.

--explain should give more explanation.

Recommended way is the following command:

$ appstreamcli validate --strict --explain --pedantic gtimelog.appdata.xml

I will try to force myself to read the relevant specs and see what needs to be changed. I have approximately zero motivation for this, so please do not expect a quick fix :(

Take your time.

Better appstream data will display the app properly in lots of software centers ( GNOME Software etc ).

Refer: https://www.youtube.com/watch?v=jIDk0frev7M&t=719s

@hfiguiere
Copy link
Contributor

This should probably be reported to the Debian bug tracker. The upstream Makefile doesn't do anything with the appstream file, other than running appstream-util validate.

(I'll change it to use appstreamcli).

IMHO make install should actually do that.

hfiguiere added a commit to hfiguiere/gtimelog that referenced this issue Mar 26, 2024
- Update to the newer standard (gtimelog#241)
- Set proper app id
- Add launchable

Signed-off-by: Hubert Figuière <hub@figuiere.net>
mgedmin added a commit that referenced this issue Mar 26, 2024
@mgedmin
Copy link
Member

mgedmin commented Mar 26, 2024

IMHO make install should actually do that.

I don't actually have a make install:

make: *** No rule to make target 'install'.  Pabaiga.

(that's also some amazing partial translation of the error message in GNU Make's lt_LT.po.)

@hfiguiere
Copy link
Contributor

there should be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants