Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clicking on games sometimes won't open the card with information #81

Open
MakoSipper opened this issue Mar 30, 2019 · 1 comment
Labels
bug Scrapers Issues related to scraping games, stores and external content

Comments

@MakoSipper
Copy link

Examples:

  • Noticed with games 303850 and 391920.
  • App 67910 is a video; The image is correct, but it shows its name as Farming Simulator 2011 for some reason.
  • App 488250 is also a video. Log below (from Chrome's console, all of these examples seem to generate similar logs, 4 errors each click):
LogRocket.min.js:1 [Vue warn]: Error in render: "TypeError: Cannot read property 'windows' of null"

(found in <Root>)
e.(anonymous function) @ LogRocket.min.js:1
warn @ bundle.js?v=3-3-23:58966
logError @ bundle.js?v=3-3-23:60178
globalHandleError @ bundle.js?v=3-3-23:60173
handleError @ bundle.js?v=3-3-23:60162
Vue._render @ bundle.js?v=3-3-23:62998
updateComponent @ bundle.js?v=3-3-23:61249
get @ bundle.js?v=3-3-23:61619
run @ bundle.js?v=3-3-23:61694
flushSchedulerQueue @ bundle.js?v=3-3-23:61450
(anonymous) @ bundle.js?v=3-3-23:60279
flushCallbacks @ bundle.js?v=3-3-23:60198
LogRocket.min.js:1 TypeError: Cannot read property 'windows' of null
    at Proxy.eval (eval at createFunction (bundle.js?v=3-3-23:69153), <anonymous>:3:3981)
    at Vue._render (bundle.js?v=3-3-23:62996)
    at Vue.updateComponent (bundle.js?v=3-3-23:61249)
    at Watcher.get (bundle.js?v=3-3-23:61619)
    at Watcher.run (bundle.js?v=3-3-23:61694)
    at flushSchedulerQueue (bundle.js?v=3-3-23:61450)
    at Array.<anonymous> (bundle.js?v=3-3-23:60279)
    at MessagePort.flushCallbacks (bundle.js?v=3-3-23:60198)
e.(anonymous function) @ LogRocket.min.js:1
logError @ bundle.js?v=3-3-23:60182
globalHandleError @ bundle.js?v=3-3-23:60173
handleError @ bundle.js?v=3-3-23:60162
Vue._render @ bundle.js?v=3-3-23:62998
updateComponent @ bundle.js?v=3-3-23:61249
get @ bundle.js?v=3-3-23:61619
run @ bundle.js?v=3-3-23:61694
flushSchedulerQueue @ bundle.js?v=3-3-23:61450
(anonymous) @ bundle.js?v=3-3-23:60279
flushCallbacks @ bundle.js?v=3-3-23:60198
LogRocket.min.js:1 [Vue warn]: Error in event handler for "backlog-modal-current-players": "TypeError: Cannot set property 'current' of null"

(found in <Root>)
e.(anonymous function) @ LogRocket.min.js:1
warn @ bundle.js?v=3-3-23:58966
logError @ bundle.js?v=3-3-23:60178
globalHandleError @ bundle.js?v=3-3-23:60173
handleError @ bundle.js?v=3-3-23:60162
Vue.$emit @ bundle.js?v=3-3-23:61004
./resources/assets/js/vue/vue.backlog-modal.js.window.currentPlayersForModal @ bundle.js?v=3-3-23:72772
(anonymous) @ ?format=json&appid=488250&jsonp=currentPlayersForModal&callback=jQuery33109774839784426799_1553946302770&_=1553946302773:1
LogRocket.min.js:1 TypeError: Cannot set property 'current' of null
    at Vue.<anonymous> (bundle.js?v=3-3-23:72758)
    at Vue.$emit (bundle.js?v=3-3-23:61002)
    at ./resources/assets/js/vue/vue.backlog-modal.js.window.currentPlayersForModal (bundle.js?v=3-3-23:72772)
    at ?format=json&appid=488250&jsonp=currentPlayersForModal&callback=jQuery33109774839784426799_1553946302770&_=1553946302773:1
@gsabater
Copy link
Owner

Hey @MakoSipper

You are completely right. Turns out we were storing more than games and DLC in the database.
After a quick search, steam provides videos, demos, episodes, servers, and other pieces of media.

We are going to clean the database of all this kind of stuff. I stimate a period of three months until everything has been cleared out.

Thanks a lot

@gsabater gsabater added bug Scrapers Issues related to scraping games, stores and external content labels Mar 30, 2019
@gsabater gsabater pinned this issue Apr 9, 2019
@gsabater gsabater unpinned this issue Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Scrapers Issues related to scraping games, stores and external content
Projects
None yet
Development

No branches or pull requests

2 participants