Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers messagebox, confirm and prompt to Drab.Browser #93

Open
grych opened this issue Apr 3, 2018 · 7 comments
Open

Add helpers messagebox, confirm and prompt to Drab.Browser #93

grych opened this issue Apr 3, 2018 · 7 comments

Comments

@grych
Copy link
Owner

grych commented Apr 3, 2018

This is a good, easy entry point to contribute!

@grych
Copy link
Owner Author

grych commented Apr 3, 2018

With timeout: :infinity

@grych grych changed the title Add helpers alert and confirm to Drab.Browser Add helpers alert, confirm and prompt to Drab.Browser Apr 3, 2018
@grych grych changed the title Add helpers alert, confirm and prompt to Drab.Browser Add helpers messagebox, confirm and prompt to Drab.Browser Jul 24, 2018
@richardvdveen
Copy link

@grych I would like to contribute and help resolve this issue, could you provide more context on the helpers?

@grych
Copy link
Owner Author

grych commented Oct 21, 2018

HI @Blackjaguar18, appreciated!
this is a simple wrapper around javascript alert, confirm and prompt. Please name function calling JS alert - messagebox/3, as it should not be confused with Drab.Modal.alert.
Functions should return what JS returns, so messagebox will return "undefined", confirm - boolean and prompt - string.

Please create pair of each of the functions, normal and bang - as it is done for the other functions in Drab.Modal.

Please use timeout: :infinite as default option in exec_js - we want to hold on processing while displaying an alert. Of course timeout should be overritable.

@nikhilmore54-zz
Copy link

What is the status of this issue?

@grych
Copy link
Owner Author

grych commented Apr 12, 2019

Hi @nikhilmore54, it is not finished yest

@nikhilmore54-zz
Copy link

nikhilmore54-zz commented Apr 12, 2019 via email

@grych
Copy link
Owner Author

grych commented Apr 12, 2019

Hi @nikhilmore54, appreciated!

"this is a simple wrapper around javascript alert, confirm and prompt. Please name function calling JS alert - messagebox/3, as it should not be confused with Drab.Modal.alert.
Functions should return what JS returns, so messagebox will return "undefined", confirm - boolean and prompt - string.

Please create pair of each of the functions, normal and bang - as it is done for the other functions in Drab.Modal.

Please use timeout: :infinite as default option in exec_js - we want to hold on processing while displaying an alert. Of course timeout should be overritable."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants