Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we run tests? #10

Open
jcar787 opened this issue Oct 30, 2018 · 9 comments
Open

How do we run tests? #10

jcar787 opened this issue Oct 30, 2018 · 9 comments

Comments

@jcar787
Copy link
Contributor

jcar787 commented Oct 30, 2018

I don't see any test script here in package.json. How are you guys running tests?
I think this should be added, also to maintain consistency accross the team we can add prettier and eslint.
Let me know your thoughts, I'm really excited about this

@DanielRuf
Copy link

DanielRuf commented Oct 30, 2018

Would be good to have some tests, probably based on puppeteer and Browserstack.

@gruns
Copy link
Owner

gruns commented Nov 2, 2018

Thus far, I've run a simple webserver in the root directory

$ http-server -p 5050 &
$ google-chrome "http://localhost:5050/testing/test.html"

and tested manually via testing/test.html. This is, obviously, boorish.

IronDB needs automated tests.

Until I get around to this, pull requests graciously welcome.

@jcar787
Copy link
Contributor Author

jcar787 commented Nov 2, 2018

IIn the PR I did for using lodash functions instead of the whole library, I added a webpack-server to make the test in the browser easier using npm run serve.
I can add that again if you want.
Also we can add another set of unit tests using jest and then add the tests using puppeteer.
That's my thought at least.
Let me know. If that works.

@gruns
Copy link
Owner

gruns commented Dec 4, 2018

IIn the PR I did for using lodash functions instead of the whole library, I
added a webpack-server to make the test in the browser easier using npm run
serve. I can add that again if you want.

I saw that. That was great. So great, I added it back out of band.

Thank you.

Also we can add another set of unit tests using jest and then add the tests
using puppeteer. That's my thought at least. Let me know. If that works.

That would awesome; ImmortalDB needs automated tests.

Do you have experience with Jest and/or Puppeteer? Would you be able to start on
such tests?

@jcar787
Copy link
Contributor Author

jcar787 commented Dec 13, 2018

Sorry, for the delay in my response.
I have experience on Jest no Puppeteer.
I can start working in some jest tests and leave the door open for Puppeteer if someone else likes to take that task.

@DanielRuf
Copy link

Afaik there is jest-puppeteer to simplify the integration.

@DanielRuf
Copy link

https://www.npmjs.com/package/jest-puppeteer

@gruns
Copy link
Owner

gruns commented Dec 14, 2018

I can start working in some jest tests and leave the door open for Puppeteer
if someone else likes to take that task.

Awesome. Tests will be sick.

I have no experience with Jest nor Puppeteer, but let me know if/where I can
help provide input.

@gruns
Copy link
Owner

gruns commented Jan 17, 2019

Until automated tests have been built, the webpack-dev-server can be started,
and the test page testing/test.html automatically opened, with:

$ npm start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants