Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Option to reduce cardinality of grpc_server_handled_total #93

Open
glukasiknuro opened this issue Jun 5, 2020 · 4 comments
Open

Option to reduce cardinality of grpc_server_handled_total #93

glukasiknuro opened this issue Jun 5, 2020 · 4 comments

Comments

@glukasiknuro
Copy link

For each method the grpc_server_handled_total exposes currently ~17 labels, per each status code. In most cases having just SUCCESS / FAILURE distinction would be enough, and would reduce amount of exported labels, which maybe an issue in case of multiple rpc methods.

For a single data point, imagine a server with 20 RPC methods, each replica will then exports about 400 labels just for RPC statuses.

This 17 labels looks like on par with histrogram metric, that has option to disable it because of the cardinality issue.

@brancz
Copy link
Collaborator

brancz commented Jun 9, 2020

Are you asking for lazy initialization or the ability to add/remove labels?

@glukasiknuro
Copy link
Author

Option to change grpc_server_handled_total - or something similar - to expose binary SUCCESS / FAILURE status instead of having one label per status.

@brancz
Copy link
Collaborator

brancz commented Jun 9, 2020

Got it. I think that request is reasonable, however, keep in mind that we are in the process of reworking this project (RE: #91), and as a result we are unlikely to accept PRs that are not bug fixes. That said I think this would be an amazing addition to the reworked version! :) cc @bwplotka

@bwplotka
Copy link
Collaborator

bwplotka commented Jun 9, 2020

Yes! We are looking for some help as well on that (:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants