Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto translation failing when message in front matter is wrapped by quotes #824

Open
CrystalOnScript opened this issue Aug 24, 2018 · 4 comments
Assignees
Labels

Comments

@CrystalOnScript
Copy link

Hello there!

Translations aren't being picked up when strings are wrapped in quotes.

We have a string that ends in a colon " : " so we've wrapped it in quotes to prevent breaking. Unfortunately, this string isn't updating to provided translations in .po files.

@Zoramite
Copy link
Member

Zoramite commented Sep 4, 2018

Can you give me an example of the front matter that you are using that isn't being captured for translation and I'll check it out?

@Zoramite Zoramite self-assigned this Sep 4, 2018
@Zoramite Zoramite added the bug label Sep 4, 2018
@CrystalOnScript
Copy link
Author

Sure! Here was the PR opened:
ampproject/amp.dev#1122

Let me know if this is sufficient or if you need further information.
Thanks!

@Zoramite
Copy link
Member

Zoramite commented Oct 2, 2018

I've tested the export process with strings ending in : and enclosed in quotes, but I'm not seeing any problems extracting it for translation.

@CrystalOnScript
Copy link
Author

It may be a different cause to the bug. I apologize for not being more specific before.

This ss shows two translated strings between the home.yaml file and the id/LC_messages/messages.po file:
screen shot 2018-10-02 at 12 37 20 pm

SS of home.yaml:
screen shot 2018-10-02 at 12 38 18 pm

Its working for the button:
screen shot 2018-10-02 at 12 38 07 pm

But not working for the string:
screen shot 2018-10-02 at 12 37 38 pm

Any idea what would be causing this? The only two differences I've been able to spot is the use of quotes and a colon.

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants