Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete shapes because of roundabout #161

Open
nlehuby opened this issue Aug 3, 2020 · 1 comment
Open

Incomplete shapes because of roundabout #161

nlehuby opened this issue Aug 3, 2020 · 1 comment
Labels

Comments

@nlehuby
Copy link
Collaborator

nlehuby commented Aug 3, 2020

In OpenStreetMap, it is very common to have roundabout represented as a unique closed way. This roundabout may then be used as part as bus route relations.

Even if it is cleaner to cut the roundabout in separate ways at each relevant intersection to have a continuous bus route, using a closed way of the entire roundabout in the relation is usually not considered an error in OpenStreetMap.

But osm2gtfs does fail to generate the shape because of the closed way.

For instance, for this bus route
image

the shape generated is cut at the first un-cut roundabout met:
image

A valid fix would be to ignore and skip closed way on the shape building.

@nlehuby nlehuby added the bug label Aug 3, 2020
nlehuby added a commit to Jungle-Bus/osm2gtfs that referenced this issue Aug 3, 2020
nlehuby added a commit to Jungle-Bus/osm2gtfs that referenced this issue Aug 3, 2020
@nlehuby
Copy link
Collaborator Author

nlehuby commented Aug 3, 2020

I have a fix ready:
image

Jungle-Bus/osm2gtfs@python3...Jungle-Bus:fix_shapes

But we need to merge #160 first 😉

nlehuby added a commit that referenced this issue Aug 7, 2020
nlehuby added a commit that referenced this issue Aug 7, 2020
nlehuby added a commit to Jungle-Bus/osm2gtfs that referenced this issue Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant