Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search suggestions: Trailing comma when no city/place is given #908

Open
ialokim opened this issue Jan 7, 2024 · 0 comments · May be fixed by #947
Open

Search suggestions: Trailing comma when no city/place is given #908

ialokim opened this issue Jan 7, 2024 · 0 comments · May be fixed by #947
Labels
bug 🐞 A functional defect or unexpected behavior.

Comments

@ialokim
Copy link
Collaborator

ialokim commented Jan 7, 2024

Describe the bug
Encountered while testing #901. Might be a problem of the upstream VRS API, but Transportr should handle this case gracefully.

To Reproduce
Steps to reproduce the behavior:

  1. Select VRS
  2. Search for 'Köln'
  3. See that 'Köln Hbf,' is displayed among the results (mind the trailing comma)

Expected behavior
If no additional city/place is given, the comma should be omitted.

Screenshots
grafik

Versions (please complete the following information):

  • Transportr Version: 2.2.0-dev
@ialokim ialokim added the bug 🐞 A functional defect or unexpected behavior. label Jan 7, 2024
@ialokim ialokim mentioned this issue Jan 7, 2024
Merged
@Altonss Altonss linked a pull request May 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 A functional defect or unexpected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty place display Altonss/Transportr
1 participant
@ialokim