Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display time zone option to "Timestamp" #835

Closed
tomtosi opened this issue Sep 8, 2016 · 4 comments · Fixed by #1353
Closed

Add display time zone option to "Timestamp" #835

tomtosi opened this issue Sep 8, 2016 · 4 comments · Fixed by #1353
Labels
help wanted Would appreciate community help working on this

Comments

@tomtosi
Copy link

tomtosi commented Sep 8, 2016

Add time zone option to "Timestamp"

Expected Behavior

For circumstances where it is not feasible to display the date/time in user's time zone but instead must use a global reference, need the option to display the time zone (e.g. "UTC") in the time stamp.

Actual Behavior

There is currently no option to indicate (within the timestamp) what time zone is being referenced.

URL, screen shot, or Codepen exhibiting the issue

http://grommet.github.io/hpe/docs/timestamp

Steps to Reproduce

NA

Your Environment

NA

@ericsoderberghp ericsoderberghp added the help wanted Would appreciate community help working on this label Nov 2, 2016
@tracybarmore tracybarmore added the needs attention To alert grommet team that a PR has been waiting for the author for a while label Jan 10, 2017
@ericsoderberghp ericsoderberghp removed their assignment Jan 31, 2017
@dgennetten dgennetten assigned dgennetten and unassigned dgennetten May 5, 2017
@dgennetten
Copy link
Contributor

dgennetten commented May 10, 2017

This thread illuminates the difficulty of this request moment/moment#162

@dgennetten dgennetten self-assigned this May 11, 2017
@dgennetten dgennetten added this sprint in progress Currently in development and removed this sprint in progress Currently in development labels May 11, 2017
@dgennetten
Copy link
Contributor

@alansouzati #1353 does not address this timezone issue

@alansouzati alansouzati reopened this May 15, 2017
@alansouzati
Copy link
Member

sorry github closed it automatically.

@tracybarmore tracybarmore added this sprint and removed needs attention To alert grommet team that a PR has been waiting for the author for a while labels May 16, 2017
@dgennetten dgennetten removed their assignment Jun 22, 2017
@alansouzati
Copy link
Member

this would require another package that handles timezones with names like America\Los_Angeles which seems very vendor specific.

It is likely the timestamp will be removed in 2.0 as it is just a tiny wrapper around moment-js.

I don't see ourselves adding much more support for timestamp as it stands today. I'm going to close this issue because of this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Would appreciate community help working on this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants