Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make it possible to show out of stock products in Stock overview #2398

Open
alkuzman opened this issue Dec 9, 2023 · 3 comments

Comments

@alkuzman
Copy link
Contributor

alkuzman commented Dec 9, 2023

I know this was requested before, but I believe it is still relevant.
It is not the case that something is not possible to do with the current setup, however, the user expectation to check the stock of a particular item by searching in the stock overview page is reasonable. Currently, if you search for an item that is out of stock and has no minimum amount (like most recipe ingredients do) you will find nothing. This creates confusion on whether the product exists at all. Then we have to switch to the product page, which is an extra step for no particular reason.

Moreover, the stock overview page contains some statistics that are not visible on the product pages (for now last and average price, but in the future, I hope for more). I know these statistics and more are visible if I click on the product, but that is another extra step.

What I am asking for is this to be at least an option. By default, they can still be hidden, but it should be possible to remove this filter on demand.

 

Edit by @berrnd: Request template violation - off-topic part minimized / will be ignored and not tracked here While I am on this topic, it would be also nice if the item model for the `/stock` API call would be the same as `/stock/products/{productId}`. I just believe that the model on `/stock/products/{productId}` is quite good and complete for most things that anyone will ever need. Also, having fewer models would be better for maintainability I guess.
@berrnd
Copy link
Member

berrnd commented Dec 9, 2023

First, let's clarify once again that /stockoverview is supposed to show an overview of your stock and that /products lists all products as part of master data management - both is already implied by the naming.

 

What I am asking for is this to be at least an option. By default, they can still be hidden

If, then it's an optional new product option (we definitely have not enough of them) like "Always show on stock overview" disabled by default - changing a default behavior for everyone based on your very personal likings is never the way to go.

@berrnd

This comment was marked as off-topic.

@alkuzman
Copy link
Contributor Author

Sorry for the topic switch. I will create another issue for that.

If, then it's an optional new product option (we definitely have not enough of them) like "Always show on stock overview" disabled by default - changing a default behavior for everyone based on your very personal likings is never the way to go.

Maybe I was not clear. I intentionally left out how it should be implemented, but I never meant to be an option in the product. My idea was to be either a filter option on the stock overview page or an option in the stock settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants