Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refactor the internals of Grocer::Server, Grocer::SSLServer #11

Open
alindeman opened this issue Jun 20, 2012 · 3 comments
Open

Comments

@alindeman
Copy link
Member

We've run into weird issues, especially on different platforms (e.g., Linux vs. OS X) dealing with setting up and tearing down a Grocer.server.

This issue is to audit the code that's currently written, looking for ways to improve the ways the server socket is setup and used. We should consider stuff like whether using non-blocking/async calls is more appropriate, and how to make sure that all platforms react well to the changes.

@stevenharman
Copy link
Member

I wonder if we need some integration tests to test our integration test server.

Integration Tests

@alindeman
Copy link
Member Author

Probably! Good idea.

@kyledrake
Copy link
Contributor

You may want to investigate read_nonblock and write_nonblock, and putting things in threads (ruby does not block on IO when threads are used despite popular belief, it goes and works on another thread while waiting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants